zahiraam added inline comments.
================ Comment at: clang/test/CodeGen/X86/bfloat16.cpp:2-3 +// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py UTC_ARGS: --version 2 +// RUN: %clang_cc1 -triple x86_64-unknown-linux-gnu -target-feature +fullbf16 -S -emit-llvm %s -o - | FileCheck %s +// RUN: %clang_cc1 -triple x86_64-unknown-linux-gnu -S -emit-llvm %s -o - | FileCheck -check-prefix=CHECK-NBF16 %s + ---------------- codemzs wrote: > zahiraam wrote: > > pengfei wrote: > > > The backend has already support lowering of `bfloat`, I don't think it's > > > necessary to do extra work in FE unless for excess-precision. > > > The backend has already support lowering of `bfloat`, I don't think it's > > > necessary to do extra work in FE unless for excess-precision. > > > > +1. > @pengfei @zahiraam I added this test to verify bfloat16 IR gen functionality, > considering both scenarios: with and without native bfloat16 support. > However, if you believe it's more beneficial to omit it, I'm open to doing > so. Happy to also move this test to another target that doesn't have backend > support for emulation. I think that's fine. You can leave it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150913/new/ https://reviews.llvm.org/D150913 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
