kadircet added a comment.

In D150997#4357589 <https://reviews.llvm.org/D150997#4357589>, @nikic wrote:

> It looks like you forgot to `git add` the new file maybe?
>
> This was added in https://reviews.llvm.org/D133200, maybe @kadircet can 
> comment on what this was intended for.

It was already pointed out by you :) this is used by 
clang-tools-extra/include-cleaner/include/clang-include-cleaner/Types.h, and 
your changes there LG.
You should also update `llvm/unittests/ADT/DenseMapTest.cpp`, you can see build 
breakage information at the top (search for `pre-merge checks`).

Also, thanks for pointing out the discrepancy in implementation of `isEqual`. 
Sent out https://reviews.llvm.org/D151079. Happy to land it before or after 
your change.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150997/new/

https://reviews.llvm.org/D150997

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to