craig.topper added inline comments.
================ Comment at: clang/include/clang/Basic/riscv_vector.td:2640 + llvm::Value *VOperand = Ops[2]; + assert(isa<ConstantInt>(IndexOperand)); + ---------------- Drop this assert ================ Comment at: clang/include/clang/Basic/riscv_vector.td:2644 + unsigned MaxIndex = cast<StructType>(VTupleOperand->getType())->getNumElements(); + Index = std::min(Index, MaxIndex); + ---------------- Does this min do anything? I didn't think about it in the previous patch, but if you're trying to clip it should be `std::min(Index, MaxIndex-1)` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147917/new/ https://reviews.llvm.org/D147917 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
