shafik added a comment. In D150226#4354063 <https://reviews.llvm.org/D150226#4354063>, @efriedma wrote:
>> Also note, one of the bugs I reference shows how this breaks SFINAE: >> https://github.com/llvm/llvm-project/issues/57176 and that is not easily >> fixable. So this is non-conforming since it breaks valid code. > > You can mark a warning diagnostic SFINAEFailure to ensure it's treated as an > error in contexts where SFINAE matters. It might make sense to do that as an > intermediate step. I don't remember all the details but I noted in the bug report that b/c we are not using `CCEDiag` it seemed that won't work. At least I could not get it to work at the time and I believe that was the underlying issue but maybe I missed something. It may be worth looking into again. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150226/new/ https://reviews.llvm.org/D150226 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
