giulianobelinassi marked 4 inline comments as done and 2 inline comments as done. giulianobelinassi added a comment.
I will update the patch with the suggestions and send them again. ================ Comment at: clang/lib/AST/DeclPrinter.cpp:270 + + // FIXME: Find a way to use the AttrList.inc. We use if-else statements + // to classify each of them. ---------------- aaron.ballman wrote: > erichkeane wrote: > > I think this is something we need to just do the right way, right away. > > The below is completely unsustainable, and is just going to encourage us to > > spend the next few years messing with this if/else-if tree. I'll leave > > final judgement to Aaron, but just making this its own function dependent > > on TableGen'ed files seems like what we should be doing from the start. > As much as I hate to obligate anyone to get involved in tablegen to solve a > problem, I share the concern that this is not an extensible approach. I think > @giulianobelinassi should move forward by trying to emit this from > ClangAttrEmitter.cpp if at all possible. I will do the TableGen approach, then.. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141714/new/ https://reviews.llvm.org/D141714 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
