nridge accepted this revision. nridge added a comment. This revision is now accepted and ready to land.
Thanks! Let me know if you need me to commit. ================ Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:406 public: - HighlightingsBuilder(const ParsedAST &AST, bool IncludeInactiveRegionTokens) + HighlightingsBuilder(const ParsedAST &AST, HighlightingFilter Filter, + bool IncludeInactiveRegionTokens) ---------------- The filter can be passed by const reference in the constructor (and it's better to do so to avoid making an additional copy), it just needs to be stored by value as a class member Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148489/new/ https://reviews.llvm.org/D148489 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
