alexshap added inline comments. ================ Comment at: clang-reorder-fields/ReorderFieldsAction.h:31 @@ +30,3 @@ + +public: + ReorderFieldsAction( ---------------- djasper wrote: > I don't why clang-rename does what it does at the moment. My main point is > that we have already implemented splitting up replacements by file in > groupByReplacementsByFile. No need to reimplement that here or make the > interface of this function more complex than it needs to be. sorry, i am not sure i got ur comment - need to think - maybe i am too sleepy - the issue is not with clang-rename, but with class RefactoringTool and more precisely with the method the method getReplacements.
Repository: rL LLVM https://reviews.llvm.org/D23279 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
