srhines added inline comments. ================ Comment at: lib/Sema/SemaChecking.cpp:3856 @@ -3855,3 +3855,3 @@ // format string, we will usually need to emit a warning. // True string literals are then checked by CheckFormatString. static StringLiteralCheckType ---------------- It might be good to mention that Offset now goes back to the caller to allow for checking of string literal suffixes.
================ Comment at: lib/Sema/SemaChecking.cpp:3900 @@ +3899,3 @@ + // We need to maintain the offsets for the right and the left hand side + // seperately to check if every possible indexed expression is a valid + // string literal. They might have different offsets for different string ---------------- separately https://reviews.llvm.org/D23820 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
