cor3ntin added a comment. I think this is starting to look good, My biggest question is the remaining fixme, how much work would it be to do in this PR?
================ Comment at: clang/include/clang/Sema/TemplateDeduction.h:237 + // C++ [over.match.class.deduct]p5.2: + // During template argument deduction for the aggregate deduction ---------------- Can you specify which c++ version this quote is from? ================ Comment at: clang/lib/Sema/SemaTemplate.cpp:2597 + // constructors into deduction guides. + // FIXME: Add a kind for this to give more meaningful diagnostics. + InstantiatingTemplate BuildingDeductionGuides(*this, Loc, Template); ---------------- Maybe you could do this in this PR? ================ Comment at: clang/www/cxx_status.html:1249 <td><a href="https://wg21.link/p1816r0">P1816R0</a></td> - <td rowspan=2 class="none" align="center">No</td> + <td rowspan=2 class="unreleased" align="center">Clang 17</td> </tr> ---------------- I think this should be marked a partially supported until we support parenthesized init. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139837/new/ https://reviews.llvm.org/D139837 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits