HazardyKnusperkeks added a comment. Please add the full stop to the code comment(s), and then mark review comments as done.
You should also give credit to @sstwcw in the commit message/differential description for the token annotator tests. In D150403#4339530 <https://reviews.llvm.org/D150403#4339530>, @sstwcw wrote: > I would suggest adding a link to the revision on the issue thread for your > future bug fixes. So people like me don't try to fix what others have fixed. That's correct, you could even assign the issue to you (or ask to be done so), to show that someone is working on it. ================ Comment at: clang/unittests/Format/TokenAnnotatorTest.cpp:44 +#define EXPECT_BRACE_KIND(FormatTok, Kind) \ + EXPECT_EQ(FormatTok->getBlockKind(), Kind) #define EXPECT_TOKEN(FormatTok, Kind, Type) \ ---------------- To be consistent, and to get a better output when the expect fails. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150403/new/ https://reviews.llvm.org/D150403 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
