jmmartinez added inline comments.

================
Comment at: llvm/lib/Target/AMDGPU/SIMemoryLegalizer.cpp:524
+         SIAtomicAddrSpace::NONE)
+      return enableSC0Bit(MI) | enableSC1Bit(MI);
+    return false;
----------------
NIT: Is the use of the bitwise or " | " intended? I'd use the logical or " || " 
instead.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149986/new/

https://reviews.llvm.org/D149986

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D149... Matt Arsenault via Phabricator via cfe-commits
    • [PATCH]... Konstantin Zhuravlyov via Phabricator via cfe-commits
    • [PATCH]... Juan Manuel Martinez Caamaño via Phabricator via cfe-commits
    • [PATCH]... Konstantin Zhuravlyov via Phabricator via cfe-commits
    • [PATCH]... Pierre van Houtryve via Phabricator via cfe-commits
    • [PATCH]... Konstantin Zhuravlyov via Phabricator via cfe-commits
    • [PATCH]... Konstantin Zhuravlyov via Phabricator via cfe-commits
    • [PATCH]... Scott Linder via Phabricator via cfe-commits
    • [PATCH]... Matt Arsenault via Phabricator via cfe-commits

Reply via email to