codemzs marked 2 inline comments as done. codemzs added inline comments.
================ Comment at: clang/include/clang/Basic/LangOptions.def:468 +LANGOPT(ExperimentalNewItaniumMangling, 1, 0, "experimental new Itanium mangling") + ---------------- erichkeane wrote: > codemzs wrote: > > erichkeane wrote: > > > I'm not sure I like the implications or maintainability of this. This is > > > something that is likely to get out of hand too quickly. We probably > > > need to just figure out what the itanium mangling is GOING to be (perhaps > > > @rjmccall has some insight?), and just implement that. > > > > > > Also, this isn't really a 'Language Option', so much as a codegen option. > > Thank you for your valuable feedback. Based on your suggestion and > > considering that GCC has already implemented the mangling as `DF16b`, I > > agree that if we have reasonable confidence in the direction the mangling > > will take, it would be better to implement it directly instead of guarding > > it with an experimental flag. Therefore, I will be removing the flag. I > > initially added the flag since @tahonermann was on board with implementing > > the bf16 arithmetic type, assuming the mangling was finalized. > > > > However, I understand your concerns and would appreciate further input from > > both @tahonermann and @rjmccall on this matter. My intention is to avoid > > stalling the progress of this change due to mangling finalization. > > > > I'm open to further discussion and collaboration to ensure we make the > > right decision for our project while maintaining the momentum of the review > > process. > Thanks, I think this is a good direction for this patch to take. @erichkeane @tahonermann Itanium mangling is now finalized as `DF16b`and [[ https://github.com/itanium-cxx-abi/cxx-abi/pull/147#issuecomment-1540692344 | merged ]]into the github repository. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149573/new/ https://reviews.llvm.org/D149573 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
