MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land.
> The linker is just lld so it should be the same conceptually. I'm just > figuring that even if the user is cross compiling we should respect -L passed > on the command line. Should I change this patch to make that change? So it seems that there are configurations that we need -L (cross compilation?). If we forward -L in some configurations, I think it'd be better to do this consistently. The `LIBRARY_PATH` options seems not useful and the conditional `if (not cross compiling) add LIBRARY_PATH` is more unfortunate. I wish that we don't add more cases that we do something with `LIBRARY_PATH`. (IMO the `LIBRARY_PATH` users can just fix their build system or use `CCC_OVERRIDE_OPTIONS`) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150013/new/ https://reviews.llvm.org/D150013 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
