erichkeane accepted this revision.
erichkeane added a comment.
This revision is now accepted and ready to land.
Give folks another 48 hrs to disagree, but this seems fine to me/consistent
with other comments.
================
Comment at: clang/lib/Sema/SemaDecl.cpp:1824
-static bool isUsingDecl(NamedDecl *D) {
+static bool isUsingDeclAtClassScope(NamedDecl *D) {
+ if (D->getDeclContext()->isFileContext())
----------------
ChuanqiXu wrote:
> This is the ad-hoc change. Look at the following comment.
So this name isn't really what you're doing.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D148506/new/
https://reviews.llvm.org/D148506
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
