tbaeder added inline comments.
================
Comment at: clang/test/AST/Interp/literals.cpp:783
+
+namespace PredefinedExprs {
+ constexpr char heh(unsigned index) {
----------------
aaron.ballman wrote:
> tbaeder wrote:
> > shafik wrote:
> > > Can we add tests for each predefined expressions, it does not look like
> > > there are a lot of them.
> > Not sure that adds much value? Didn't the output of `__PRETTY_FUNCTION__`
> > change at some point in the last release even, which would make this test
> > brittle?
> The behavior doesn't change all that often and we should test that we get the
> expected results from each of the expressions. It should be straightforward:
> https://godbolt.org/z/qveWPGWjK
Oh well if you provide the test cases as well, that's of course a completely
different situation :)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D148689/new/
https://reviews.llvm.org/D148689
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
