barannikov88 added a comment. In D148767#4316464 <https://reviews.llvm.org/D148767#4316464>, @chapuni wrote:
> In D148767#4312692 <https://reviews.llvm.org/D148767#4312692>, @barannikov88 > wrote: > >> Sorry, I don't follow. They may theoretically depend on anything. Why >> CodeGen/CodeGenTypes, specifically? >> If they don't require it, why add it? > > I added deps pessimistically, "This depends on CodeGenTypes if LowLevelType.h > is included". Sorry if I was not being clear. Dependencies are harmful and should be avoided wherever possible. They should not be added "just in case". Now when I want to build just llvm-mc I have to build half of the whole stack. Although D148769 <https://reviews.llvm.org/D148769> improves the situation, it does not justify adding these dependencies. Your RFC was about dependencies, so I think you understand my concern. Please try to remove them and only keep the ones that are really necessary. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148767/new/ https://reviews.llvm.org/D148767 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
