aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land.
Just some minor nits from me, but LG with those fixed up. ================ Comment at: clang/include/clang/Basic/DiagnosticGroups.td:230-232 def CXX20Designator : DiagGroup<"c++20-designator">; +def CXX2bDefCompCallsNonConstexpr : DiagGroup<"c++2b-default-comp-relaxed-constexpr">; // Allow -Wno-c99-designator to be used to turn off all warnings on valid C99 ---------------- ================ Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:9425 + "invokes a non-constexpr comparison function is a C++2b extension">, + InGroup<CXX2bDefCompCallsNonConstexpr>; +def warn_cxx2b_compat_defaulted_comparison_constexpr_mismatch : Warning< ---------------- Note, you should coordinate the `2b`->`23` changes with https://reviews.llvm.org/D149553 ================ Comment at: clang/www/cxx_status.html:1486 + <summary>Clang 17 (Partial)</summary> + We do not support outside of defaulted special memeber functions the change that constexpr functions no + longer have to be constexpr compatible but rather support a less restricted requirements for constexpr ---------------- Indentation looks a bit off here. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146090/new/ https://reviews.llvm.org/D146090 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
