owenpan added inline comments.

================
Comment at: clang/lib/Format/Format.cpp:3486-3489
+      Expanded.InsertBraces = true;
+      Passes.emplace_back([&](const Environment &Env) {
+        return BracesInserter(Env, Expanded).process(/*SkipAnnotation=*/true);
       });
----------------
tahonermann wrote:
> How about using an init capture instead? This will suffice to avoid one of 
> the copies but means that `InsertBraces` doesn't get set until the lambda is 
> invoked. I wouldn't expect that to matter though.
I'm not sure if it's worth the trouble, but if I really had to bother, I would 
do something like the above.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149647/new/

https://reviews.llvm.org/D149647

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to