aaron.ballman added a comment. In D149380#4311237 <https://reviews.llvm.org/D149380#4311237>, @dblaikie wrote:
> Seems more stylistic/unlikely to meet the diagnostic bar (certtainly couldn't > be on-by-default for instance) for clang to me (but could go into something > like clang-tidy), at least. +1 -- we expect new diagnostics to be ones we can enable by default (experience has shown us that off-by-default warnings don't typically get enabled often enough to be worth adding except for special circumstances), and there's basically no way to enable this by default. However, it does seem appropriate as a clang-tidy check: https://clang.llvm.org/extra/clang-tidy/Contributing.html Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149380/new/ https://reviews.llvm.org/D149380 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
