dexonsmith added subscribers: iana, ributzka.
dexonsmith added a comment.

In D103930#4310061 <https://reviews.llvm.org/D103930#4310061>, @ivanmurashko 
wrote:

> Friendly ping
>
> @arphaman, @jansvoboda11, I have made the patch buildable on all platforms 
> and have all tests passed. There was also a small fix (temp path for modules 
> artefact) at the test that could fix its run on some platforms. Could you 
> look at it? Does it have any issues on your side?

Alternatively, maybe @vsapsai, @ributzka, or @iana...?

Given that header maps are somewhat Apple-specific and unit test coverage is a 
bit lacking for these sorts of interactions, it'd be nice for someone to check 
this with Apple-internal stuff. But if you're okay with it landing, and then 
you triage internal issues not covered by public tests later, please say that 
as well!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103930/new/

https://reviews.llvm.org/D103930

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to