rsundahl marked an inline comment as done. rsundahl added a comment. @kcc @eugenis @MaskRay @vitalybuka Ok to go with this? All new functionality is under the added flag so not expecting any surprises. Rename asabi->asan_abi as suggested.
================ Comment at: compiler-rt/lib/asabi/CMakeLists.txt:2 +# Build for the ASAN Stable ABI runtime support library. +set(ASABI_SOURCES + asabi_shim.cpp ---------------- rsundahl wrote: > vitalybuka wrote: > > does it need to be asabi? > > maybe better asan_abi, files and macro? > The idea is that "asabi" replaces "asan" (where the "s" stands in for > "stable"), but I understand the distraction of sounding like a hot condiment! > I wonder what you think of "asan_stable" (over "asan_stable_abi" or > "asan_abi" as you suggest). I am more at ease with emphasizing the "stable" > over the "abi" since both "asan" and "asan_stable" share ABI-ness without > calling it out. This might read and organize a bit more naturally with what > we already have. Thanks for the input. Changed "asabi" namespace to "asan_abi". Applied to files, directories and contents. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143675/new/ https://reviews.llvm.org/D143675 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
