xazax.hun added inline comments.
================
Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowEnvironment.h:189
+ /// Deprecated. Use *getDataflowAnalysisContext().getOptions().Log instead.
Logger &logger() const { return *DACtx->getOptions().Log; }
----------------
bazuzi wrote:
> xazax.hun wrote:
> > Any reason for a comment as opposed to the deprecated attribute?
> I couldn't tell exactly what the conventions were or whether all of the
> chained replacements could be used as the FIX very well.
>
> If you can confirm that `LLVM_DEPRECATED("DataflowAnalysisContext is now
> directly exposed.", "*getDataflowAnalysisContext().getOptions().Log")`,
> `LLVM_DEPRECATED(..., "getDataflowAnalysisContext().arena")`, etc. will
> provide useful fixes, happy to replace with those. Or with replacements just
> in the MSG and "" for FIX otherwise.
Unfortunately, I am also not 100% sure what is the convention. But I am OK with
not providing a FIXIT here. I do not expect too many clients yet.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149464/new/
https://reviews.llvm.org/D149464
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
