manmanren added a comment.
I will update this patch once the 2nd patch is done.
Thanks for reviewing,
Manman
================
Comment at: lib/AST/Type.cpp:1095
@@ +1094,3 @@
+ return ctx.getQualifiedType(argType, splitType.Quals);
+ // Apply protocol lists if exists. Should we combine protocol list?
+ if (const auto *objcPtr = dyn_cast<ObjCObjectPointerType>(argType)) {
----------------
doug.gregor wrote:
> I think we should combine the protocol lists.
I did combine the protocol lists in the implementation, but forgot to remove
the comments :]
================
Comment at: lib/AST/Type.cpp:1290
@@ +1289,3 @@
+/// in @implementation. @implementation does not take type parameters.
+QualType QualType::handleObjCTypeParamType(ASTContext &ctx) const {
+ return simpleTransform(ctx, *this,
----------------
doug.gregor wrote:
> I think you won't need this if you take the approach I suggested on the
> previous patch of making ObjCTypeParamType type sugar for, effectively, the
> type you're computing here.
I will update this once we fix the previous patch.
https://reviews.llvm.org/D23080
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
