mikecrowe added a comment. Thanks for all the reviews.
In D149280#4301188 <https://reviews.llvm.org/D149280#4301188>, @njames93 wrote: > It may be a good idea to create unittests for the formatconverter in > `clang-tools-extra/unittests/clang-tidy/` I started there but had decided that the easiest and most reviewable form for the tests was in lit tests since the code that uses `FormatStringConverter` is so simple. (Particularly since I was hoping to persuade the inventor of `std::format` to review the tests too.) Are you proposing that I should duplicate (most of) the lit tests in the unit tests or migrate most of the lit tests to unit tests? Are there any existing tests that do similar things that I should model them on? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149280/new/ https://reviews.llvm.org/D149280 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
