rsmith added a comment.
LGTM, I'll leave approval to @shafik :)
================
Comment at: clang/lib/Sema/SemaInit.cpp:5379
+ } else {
ArrayLength = Args.size();
+ }
----------------
Can we assert that we have an `IncompleteArrayType` here? (That is, that we
don't have a `DependentSizedArrayType`.)
================
Comment at: clang/lib/Sema/SemaInit.cpp:5513
+ InitializedEntity SubEntity =
+ InitializedEntity::InitializeMember(FD, &Entity);
+ InitializationKind SubKind = InitializationKind::CreateValue(
----------------
Is there a reason to not use `InitializeMemberFromParenAggInit` here? That'd
mean we use the same `InitializedEntity` for every case in this loop, and could
pull it out of the individual `if` branches.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D148274/new/
https://reviews.llvm.org/D148274
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
