balazske marked an inline comment as done.
balazske added inline comments.

================
Comment at: clang/test/Analysis/Inputs/std-c-library-functions.h:1-2
+typedef typeof(sizeof(int)) size_t;
+typedef signed long ssize_t;
+typedef struct {
----------------
steakhal wrote:
> `ssize_t`'s size should match the size of `size_t`. In this implementation, 
> it would be true only if `size_t` is `long`.
> 
I could not find a working way of defining the type in that way (there is no 
`__sizte_t`). The current definition should work well in the test code, the 
property of being the same size is supposedly not used in the tests. The 
previous definition was not better than this (and different in different 
places).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149158/new/

https://reviews.llvm.org/D149158

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to