aaron.ballman accepted this revision.
aaron.ballman added a comment.

LGTM!



================
Comment at: clang/test/Lexer/char-literal.cpp:49
+#ifndef __cplusplus
+// expected-error@-2 {{universal character name refers to a control character}}
+#endif
----------------
cor3ntin wrote:
> I think these tests would be clearer with a different verify tag rather than 
> an ifdef, but it's kinda preexisting so feel free to ignore.
That'd be a nice cleanup for post-commit though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149098/new/

https://reviews.llvm.org/D149098

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to