carlosgalvezp added a comment.

Thanks for the refactoring, great to remove some code duplication!

As a reviewer it's not possible for me to confidently review the functional 
changes to `areStatementsIdentical`, since they don't show side by side as they 
are in different files. Please perform the move in one NFC patch, and apply the 
functional changes in a separate patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148995/new/

https://reviews.llvm.org/D148995

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to