arsenm added a comment.

In D142907#4288247 <https://reviews.llvm.org/D142907#4288247>, @efriedma wrote:

> Given that, I don't follow the whole "merging" thing... we should just be 
> setting whatever mode is active.  The attribute setting should not depend on 
> whether the function is interposable.  If you have a ODR function, all 
> definitions must have a mode compatible with whatever mode will be used at 
> runtime.  If you have a non-ODR weak function, optimizations shouldn't 
> propagate that mode from the callee to the caller.

The point is to have code that works with either mode. The intent is to avoid 
duplicating code for an extremely marginal difference. Having to duplicate 
every library function for denormal flushing and ieee handling defeats the 
purpose. The specialization will be realized after linking / inlining


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142907/new/

https://reviews.llvm.org/D142907

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to