erichkeane added a comment. In D148925#4287497 <https://reviews.llvm.org/D148925#4287497>, @tbaeder wrote:
> In D148925#4287218 <https://reviews.llvm.org/D148925#4287218>, @erichkeane > wrote: > >> So things cast to 'void' can have side effects, right? Does the call to >> discard still evaluate them? >> >> https://godbolt.org/z/a3ej9bxKe > > Yes. `discard(E)` is just `visit(E)`, except that it sets `DiscardResult` to > `true` for that one level of visiting. Following `visit()` calls will have > `DiscardResult = false` again. Cool! Mind adding the tests I proposed? it would be nice to ensure/show side-effects are guaranteed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148925/new/ https://reviews.llvm.org/D148925 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
