aaron.ballman added inline comments.

================
Comment at: clang/lib/Sema/SemaExpr.cpp:10307
       CXXCastPath Path;
       CheckPointerConversion(RHS.get(), LHSType, Kind, Path,
                              /*IgnoreBaseAccess=*/false, Diagnose);
----------------
erichkeane wrote:
> Does the LHSType here need switching too?  Or are we just going to use the 
> 'normal' pointer conversion rules here?
The intent is to follow the normal conversion rules here -- this just allows us 
to check those rules properly when the LHS type is atomic as well as when it's 
non-atomic.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148730/new/

https://reviews.llvm.org/D148730

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to