akyrtzi added inline comments.
================
Comment at: clang/tools/clang-scan-deps/ClangScanDeps.cpp:905
+ if (BriefResult) {
+ llvm::outs() << "num modules: " << FD->getNumModules() << '\n';
+ return HadErrors;
----------------
jansvoboda11 wrote:
> akyrtzi wrote:
> > jansvoboda11 wrote:
> > > This assumes `FD` is not empty, i.e. the `-format experimental-full`
> > > argument. We should probably error out early if that's not the case.
> > >
> > > WDYT about changing the new `-brief` flag into something like `-format
> > > experimental-brief`? We could avoid the dependency between arguments and
> > > we'd also make it clear the `make` and `p1689` don't have a brief variant.
> > > This assumes FD is not empty,
> >
> > Ah, good catch! I'll fix.
> >
> > > WDYT about changing the new -brief flag into something like -format
> > > experimental-brief?
> >
> > I consider `-brief` orthogonal to the format kind, there's no reason we
> > can't have brief versions of the other formats.
> > I consider `-brief` orthogonal to the format kind, there's no reason we
> > can't have brief versions of the other formats.
>
> How would a brief make or P1689 output look like?
`make` could print the number of file dependencies and `P1689` maybe also
prints the number of modules (I'm not familiar with that).
In [the apple
fork](https://github.com/apple/llvm-project/blob/871776e79523b121f3a0d0b06cf582092445369f/clang/tools/clang-scan-deps/ClangScanDeps.cpp#L145)
there are additional formats added that would have the same `-brief` output as
in this patch, without any changes.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D148369/new/
https://reviews.llvm.org/D148369
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
