PiotrZSL added inline comments.
================
Comment at:
clang-tools-extra/test/clang-tidy/checkers/bugprone/exception-escape.cpp:267
const derived *p = &d;
- throw p;
} catch(base *) {
----------------
carlosgalvezp wrote:
> I run into this often as well. If you don't want to get push back during
> review because of this I advice you to disable the automatic trailing
> whitespace removal for this project. Regular source code will be fixed via
> clang-format anyway. Alternatively you will be asked to fix it in (another)
> NFC patch :)
>
> I personally don't mind a couple or two such fixes, but here there's a lot of
> them and really create noise, distracting from the actual patch.
Excuses...
================
Comment at:
clang-tools-extra/test/clang-tidy/checkers/bugprone/exception-escape.cpp:555-557
+void explicit_int_thrower() noexcept(false) {
+ throw 1;
+}
----------------
carlosgalvezp wrote:
> Why this change?
this test file tests only noexcept, not throw.
i added throw 1 just so check would still see as an throw of integer type.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D148458/new/
https://reviews.llvm.org/D148458
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
