sgraenitz accepted this revision.
sgraenitz added a comment.
This revision is now accepted and ready to land.
Thanks. Maybe you can fix this one detail and add a description like "Most of
Orc and JITLink are movinng away from JITTargetAddress and use ExecutorAddr
instead"? Otherwise LGTM.
================
Comment at: clang/lib/Interpreter/IncrementalExecutor.cpp:88
return Sym.takeError();
- return Sym->getValue();
+ return llvm::orc::ExecutorAddr(Sym->getValue());
}
----------------
I think `Sym` is a `Expected<ExecutorAddr>` already
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D148434/new/
https://reviews.llvm.org/D148434
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
