rsmith added inline comments.

================
Comment at: lib/Frontend/CompilerInstance.cpp:1503
@@ +1502,3 @@
+        if (!Module || !Module->getASTFile() ||
+            std::string(Module->getASTFile()->getName()) != ModuleFileName) {
+          // Error out if Module does not refer to the file in the prebuilt
----------------
It'd be safer to check that `FileMgr.getFile(ModuleFileName) == 
Module->getASTFile()` in case the filename gets canonicalized by the file 
manager in some way.


https://reviews.llvm.org/D23125



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to