Hahnfeld added inline comments.
================
Comment at: clang/lib/CodeGen/CodeGenAction.cpp:296
}
+ LinkModules.clear();
return false; // success
----------------
v.g.vassilev wrote:
> argentite wrote:
> > Hahnfeld wrote:
> > > This looks like a change that has implications beyond support for CUDA.
> > > Would it make sense to break this out into a separate review, ie does
> > > this change something in the current setup?
> > It actually was a separate patch: D146388 Should I submit that for review?
> > It seems to be required because we call `LinkInModules()` once for every
> > interpreter iteration.
> >
> The problem with going for a separate change is that we cannot test it.
> Landing it without a test makes the history commit unclear. This patch (and
> the tests we add here) will at least indirectly test that change.
Ok, that's why I was asking if it changes something in the current setup (ie
can be tested). Thanks for clarifying.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146389/new/
https://reviews.llvm.org/D146389
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
