alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LGTM with a couple of nits.
================
Comment at: unittests/Tooling/RecursiveASTVisitorTestExprVisitor.cpp:221
@@ +220,3 @@
+ }
+ {
+ DeclRefExprVisitor Visitor;
----------------
nit: Should this be two different tests for simplicity?
================
Comment at: unittests/Tooling/RecursiveASTVisitorTestExprVisitor.cpp:228
@@ +227,3 @@
+ // - Once for the DeclRefExpr for the use of "i" inside the lambda.
+ Visitor.ExpectMatch("i", 1, 24, /* Times = */ 2);
+ EXPECT_TRUE(Visitor.runOver(
----------------
nit: Remove all the spaces in `/*Times=*/2`.
================
Comment at: unittests/Tooling/RecursiveASTVisitorTestExprVisitor.cpp:239
@@ +238,3 @@
+ EXPECT_TRUE(Visitor.runOver(
+ "void f() { int i; [a = i + 1]{}; }",
+ DeclRefExprVisitor::Lang_CXX14));
----------------
So, C++14 allows you do that? Wow, TIL something new about C++ ;)
https://reviews.llvm.org/D23204
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
