yaxunl added inline comments.

================
Comment at: lib/CodeGen/CodeGenModule.cpp:101
@@ -100,3 +100,3 @@
   DoubleTy = llvm::Type::getDoubleTy(LLVMContext);
   PointerWidthInBits = C.getTargetInfo().getPointerWidth(0);
   PointerAlignInBytes =
----------------
joey wrote:
> What if you create a new function in TargetInfo called 
> getMaxPointerWidth(unsigned AddrSpace), and call that here? That would by 
> default just call 'getPointerWidth', but in your AMDGPU TargetInfo you can 
> override that.
> That feels more generic.
Thanks for your suggestion. There are some other changes needed in addition to 
that.


https://reviews.llvm.org/D23361



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to