agozillon added a comment.

All the mechanisms for this patch to now function are upstream, so I believe it 
is ready for a review if at all possible @kiranchandramohan @awarzynski and 
other reviewers that this patch may be of interest to.

Although if we wish for it to be split into two separate Phabricator patches, 
one for the lowering, the other for the flag additions and attribute creation, 
I can do so. However, I think this patch gives the big picture which may be 
useful.

As a side-note there will be a follow up commit in the near future (tomorrow if 
nothing steals my attention) which will do the following:

- Add an additional mlir-translate test, as I believe I owe @kiranchandramohan 
a test I promised from another patch!
- The clang/test/Driver/flang/flang-omp.f90 will be converted into a flang 
specific test and likely moved into the existing omp-frontend-forwarding.f90 
test


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145264/new/

https://reviews.llvm.org/D145264

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to