dang added inline comments.

================
Comment at: clang/lib/ExtractAPI/DeclarationFragments.cpp:176
+
+    // id<protocol> is an qualified id type
+    if (!T->getAs<ObjCObjectPointerType>()->isObjCQualifiedIdType()) {
----------------



================
Comment at: clang/lib/ExtractAPI/DeclarationFragments.cpp:176
+
+    // id<protocol> is an qualified id type
+    if (!T->getAs<ObjCObjectPointerType>()->isObjCQualifiedIdType()) {
----------------
dang wrote:
> 
IIUC the distinction here is that `id<Protocol>` is a `id` qualified type, but 
`id<Protocol> *` is not? If so this is a fairly subtle point, and worth 
mentioning in this comment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146866/new/

https://reviews.llvm.org/D146866

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to