Author: hokein Date: Tue Aug 16 06:15:05 2016 New Revision: 278791 URL: http://llvm.org/viewvc/llvm-project?rev=278791&view=rev Log: [clang-tidy] readability-implicit-bool-cast forgets to store its options.
Reviewers: alexfh Subscribers: cfe-commits Differential Revision: https://reviews.llvm.org/D23544 Modified: clang-tools-extra/trunk/clang-tidy/readability/ImplicitBoolCastCheck.cpp clang-tools-extra/trunk/clang-tidy/readability/ImplicitBoolCastCheck.h Modified: clang-tools-extra/trunk/clang-tidy/readability/ImplicitBoolCastCheck.cpp URL: http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clang-tidy/readability/ImplicitBoolCastCheck.cpp?rev=278791&r1=278790&r2=278791&view=diff ============================================================================== --- clang-tools-extra/trunk/clang-tidy/readability/ImplicitBoolCastCheck.cpp (original) +++ clang-tools-extra/trunk/clang-tidy/readability/ImplicitBoolCastCheck.cpp Tue Aug 16 06:15:05 2016 @@ -299,6 +299,22 @@ bool isAllowedConditionalCast(const Impl } // anonymous namespace +ImplicitBoolCastCheck::ImplicitBoolCastCheck(StringRef Name, + ClangTidyContext *Context) + : ClangTidyCheck(Name, Context), + AllowConditionalIntegerCasts( + Options.get("AllowConditionalIntegerCasts", false)), + AllowConditionalPointerCasts( + Options.get("AllowConditionalPointerCasts", false)) {} + +void ImplicitBoolCastCheck::storeOptions( + ClangTidyOptions::OptionMap &Opts) { + Options.store(Opts, "AllowConditionalIntegerCasts", + AllowConditionalIntegerCasts); + Options.store(Opts, "AllowConditionalPointerCasts", + AllowConditionalPointerCasts); +} + void ImplicitBoolCastCheck::registerMatchers(MatchFinder *Finder) { // This check doesn't make much sense if we run it on language without // built-in bool support. Modified: clang-tools-extra/trunk/clang-tidy/readability/ImplicitBoolCastCheck.h URL: http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clang-tidy/readability/ImplicitBoolCastCheck.h?rev=278791&r1=278790&r2=278791&view=diff ============================================================================== --- clang-tools-extra/trunk/clang-tidy/readability/ImplicitBoolCastCheck.h (original) +++ clang-tools-extra/trunk/clang-tidy/readability/ImplicitBoolCastCheck.h Tue Aug 16 06:15:05 2016 @@ -22,12 +22,9 @@ namespace readability { /// http://clang.llvm.org/extra/clang-tidy/checks/readability-implicit-bool-cast.html class ImplicitBoolCastCheck : public ClangTidyCheck { public: - ImplicitBoolCastCheck(StringRef Name, ClangTidyContext *Context) - : ClangTidyCheck(Name, Context), - AllowConditionalIntegerCasts( - Options.get("AllowConditionalIntegerCasts", 0) != 0), - AllowConditionalPointerCasts( - Options.get("AllowConditionalPointerCasts", 0) != 0) {} + ImplicitBoolCastCheck(StringRef Name, ClangTidyContext *Context); + void storeOptions(ClangTidyOptions::OptionMap &Opts) override; + void registerMatchers(ast_matchers::MatchFinder *Finder) override; void check(const ast_matchers::MatchFinder::MatchResult &Result) override; _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
