owenpan added a comment.

You need to add `CHECK_PARSE_BOOL(SpaceBeforeJsonColon)` in ConfigParseTest.cpp.



================
Comment at: clang/include/clang/Format/Format.h:3717
 
+  /// If ``true``, a space will be add before a json colon 
+  /// \code
----------------



================
Comment at: clang/lib/Format/TokenAnnotator.cpp:4155
     if (Right.is(tok::colon))
-      return false;
+      return Style.SpaceBeforeJsonColon;
   } else if (Style.isCSharp()) {
----------------
Do we need to check if `Left.is(tok::string_literal)`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147003/new/

https://reviews.llvm.org/D147003

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to