junaire added reviewers: aaron.ballman, tbaeder, shafik. junaire added a comment.
I don't have enough context on this patch, but obviously, there's something you can improve. 1. You need to add a test, maybe somewhere in `clang/test/Sema/` 2. Please make a detailed summary of your patch so reviewers know what's going on here. You can also link the GitHub issue. ================ Comment at: clang/include/clang/Basic/DiagnosticASTKinds.td:9 -//----------------understanding syntax of diagnostics messages--------===// -//keyword after def represents symbolic constant for that diagnostics ---------------- Why delete these? Looks like unrelated changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146867/new/ https://reviews.llvm.org/D146867 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
