aaron.ballman added a comment. In D146148#4220433 <https://reviews.llvm.org/D146148#4220433>, @zahiraam wrote:
> In D146148#4220268 <https://reviews.llvm.org/D146148#4220268>, @rjmccall > wrote: > >> Okay, so modifying `math.h` to use this attribute is acceptable? That's >> great, that's definitely the best outcome for the compiler. >> >> Just a minor request about the diagnostic name, but otherwise LGTM. > > Yes. Added the attribute inside the included math.h header file. How does this work for, say, glibc, musl, or MSVC CRT? Won't those math.h headers lack the attribute and thus run into problems when used with Clang? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146148/new/ https://reviews.llvm.org/D146148 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
