sbc100 added a comment.

I just figured out that this cannot replace the current use of 
`__attribute__((used))` in emscripten because function attributes only work for 
functions and we need this mechanism to work for global data addresses too.     
There is simply no way to do something like `Fn->addFnAttr("wasm-exported");` 
for a GlobalValue that isn't a function (as far as I can tell).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76547/new/

https://reviews.llvm.org/D76547

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to