MaskRay added inline comments.
================
Comment at: clang/lib/Driver/ToolChains/AIX.cpp:125
+ // `-mroptr` implies the `-bforceimprw` linker option.
+ // The `-mroptr` option places constants in RO sections as much as possible.
----------------
Delete `// `-mroptr` implies the `-bforceimprw` linker option.` It just repeats
what the code does. Comments focus more on why/how and less on what (unless the
code is very complex and explaining "what" from a high level helps).
================
Comment at: clang/lib/Driver/ToolChains/AIX.cpp:130
+ if (Args.hasFlag(options::OPT_mroptr, options::OPT_mno_roptr, false)) {
+ CmdArgs.push_back("-bforceimprw");
+ }
----------------
drop braces
https://llvm.org/docs/CodingStandards.html#don-t-use-braces-on-simple-single-statement-bodies-of-if-else-loop-statements
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D144190/new/
https://reviews.llvm.org/D144190
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
