jdoerfert added inline comments.
================ Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:4261 + bool Temp; + return Val->getPointerDereferenceableBytes(M.getDataLayout(), Temp, Temp); } ---------------- TIFitis wrote: > `getPointerDereferenceableBytes` doesn't fully support `Arguments` and mostly > returns 0. > > I am looking at adding support for arguments in a separate patch, in the > meantime the tests added in this patch fail because of incorrect > @.offload_sizes. That function is not the right one for code generation. The sizes need to come from the type + data layout, and potentially the expression used in the map. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146557/new/ https://reviews.llvm.org/D146557 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
