dblaikie added a comment.

Yeah, we already have the return type warning and UBSan for the dynamic version 
of this check - seems OK? That a function lowers to unreachable isn't a bug - 
there's a ton of them in LLVM, quite intentionally as unimplemented functions 
that should never be called.

If the issue is with the actual fallthrough - that's been discussed elsewhere 
recently, and I think it'd be reasonable to turn on TrapOnUnreachable 
everywhere, basically (with NoTrapAfterNoreturn too, perhaps, to keep the cost 
low) so that these trivial fallthroughs hit int3 instead of going on to the 
next function.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146466/new/

https://reviews.llvm.org/D146466

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to