rjmccall added inline comments.
================ Comment at: clang/docs/LanguageExtensions.rst:3271 +4 - to nearest, ties away from zero +The effect of passing some other value to this builtin is implementation-defined. + ---------------- This comment belongs with the other builtin. I would suggest just combining these two into one section, though, like: ``` ``__builtin_flt_rounds`` and ``__builtin_set_flt_rounds`` --------------------------------------------------------- ``` That way you don't have to describe the options twice. Make sure you clarify that the target restrictions only applies to `__builtin_set_flt_rounds`. ================ Comment at: clang/docs/LanguageExtensions.rst:3280 + +Sets the current rounding mode. Encoding of the returned values is +same as the result of FLT_ROUNDS, specified by C standard: ---------------- ================ Comment at: clang/docs/LanguageExtensions.rst:3287 +4 - to nearest, ties away from zero +This builtin is restrcted to work on x86 and arm targets currently. When support +for the builtin is added for new targets, the manual should be updated accordingly. ---------------- CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146188/new/ https://reviews.llvm.org/D146188 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
