steakhal added a comment.

BTW we request full context for git patches. That way the reviewer can scroll 
and see the context around your hunks.
You can request git to emit the full context by passing the `-U999999` 
commandline option. See 
<https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface>.

As per your proposed change, I think we should do something like this:

  for (const auto *I : RD->fields()) {
    if (I->isUnnamedBitfield())
      continue;

instead of embedding this into some condition.

But I'm curious to see why does C behave differently.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146194/new/

https://reviews.llvm.org/D146194

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to